Conversation
Otherwise the test might fail, and sometimes we don't even see an error message with the reason, like observed in OBS or probably here on cpantesters: http://www.cpantesters.org/cpan/report/47446f5e-103b-11f0-98b0-b3c3213a625c http://www.cpantesters.org/cpan/report/57cba9ba-1017-11f0-98b0-b3c3213a625c
okurz
left a comment
There was a problem hiding this comment.
Oh cool. And now we have a CI failure which I have never seen before: https://github.com/openSUSE/Mojo-IOLoop-ReadWriteProcess/actions/runs/14251136067/job/39943920707?pr=78#step:6:88
|
We might want to use https://metacpan.org/pod/Proc::ProcessTable to replace pgrep |
|
If that supports process groups. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 97.78% 97.89% +0.11%
==========================================
Files 27 27
Lines 903 903
==========================================
+ Hits 883 884 +1
+ Misses 20 19 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
For the record: |
I guess that would still mean needing to read multiple lines from that table to find out all processes in a group. Not really better. PR is ok as is |
Otherwise the test might fail, and sometimes we don't even see an error message with the reason, like observed in OBS or probably here on cpantesters:
http://www.cpantesters.org/cpan/report/47446f5e-103b-11f0-98b0-b3c3213a625c http://www.cpantesters.org/cpan/report/57cba9ba-1017-11f0-98b0-b3c3213a625c